Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement wasmer login #3297

Merged
merged 19 commits into from
Nov 17, 2022
Merged

Implement wasmer login #3297

merged 19 commits into from
Nov 17, 2022

Conversation

fschutt
Copy link
Contributor

@fschutt fschutt commented Nov 10, 2022

No description provided.

@fschutt fschutt requested a review from syrusakbary as a code owner November 10, 2022 14:46
@fschutt fschutt mentioned this pull request Nov 10, 2022
Closed
Michael-F-Bryan
Michael-F-Bryan suggested changes Nov 11, 2022
View reviewed changes
lib/cli/src/commands/login.rs Outdated Show resolved Hide resolved
lib/cli/src/commands/login.rs Outdated Show resolved Hide resolved
lib/registry/src/config.rs Outdated Show resolved Hide resolved
lib/registry/src/config.rs Outdated Show resolved Hide resolved
lib/registry/src/graphql.rs Outdated Show resolved Hide resolved
lib/registry/src/graphql.rs Outdated Show resolved Hide resolved
Michael-F-Bryan
Michael-F-Bryan suggested changes Nov 11, 2022
View reviewed changes
lib/registry/src/config.rs Outdated Show resolved Hide resolved
lib/registry/src/config.rs Outdated Show resolved Hide resolved
@Michael-F-Bryan
Copy link
Contributor

@fschutt, sorry, I think I was pushing you down the wrong path by carrying on about that #[cfg(test)] stuff. I think this should be good to merge if we roll back to the commit before fcaf255 and get CI passing.

@fschutt
Copy link
Contributor Author

fschutt commented Nov 17, 2022

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 17, 2022

👎 Rejected by code reviews

@fschutt
Copy link
Contributor Author

fschutt commented Nov 17, 2022

bors r+

bors bot added a commit that referenced this pull request Nov 17, 2022
@bors @fschutt
Merge #3297
62a30a9 
3297: Implement wasmer login r=fschutt a=fschutt



Co-authored-by: Felix Schütt <[email protected]>
Co-authored-by: Felix Schütt <[email protected]>
@fschutt
Copy link
Contributor Author

fschutt commented Nov 17, 2022

bors r-

@bors
Copy link
Contributor

bors bot commented Nov 17, 2022

Canceled.

@Michael-F-Bryan
Copy link
Contributor

bors r+

@bors
Copy link
Contributor

bors bot commented Nov 17, 2022

Build succeeded:

@bors bors bot merged commit b424c9e into master Nov 17, 2022
@bors bors bot deleted the login branch November 17, 2022 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary left review comments

@Michael-F-Bryan Michael-F-Bryan Michael-F-Bryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fschutt @Michael-F-Bryan @syrusakbary